From 6c8d6e1ac7d304cf1399ac6c9e26c0e72f6aeaaf Mon Sep 17 00:00:00 2001
From: Tunui Franken <tfranken@easter-eggs.com>
Date: Wed, 9 Nov 2022 09:05:36 +0100
Subject: [PATCH] Fix lint nagging for zsh and bash roles

---
 roles/bash/tasks/main.yml | 19 ++++++++++---------
 roles/zsh/tasks/main.yml  | 18 +++++++++---------
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/roles/bash/tasks/main.yml b/roles/bash/tasks/main.yml
index 7182c67..e168d19 100644
--- a/roles/bash/tasks/main.yml
+++ b/roles/bash/tasks/main.yml
@@ -14,21 +14,22 @@
   when: ansible_facts['distribution'] == 'Debian'
 
 - name: Copy rc files
-  copy: src={{ item.src }} dest={{ item.dest }} backup=true
+  copy: src={{ item.src }} dest={{ item.dest }} backup=true mode=0644
   with_items:
-    - { src: 'inputrc', dest: '~/.inputrc' }
-    - { src: 'bash_profile.ansible', dest: '~/.bash_profile.ansible' }
-    - { src: 'bashrc.ansible', dest: '~/.bashrc.ansible' }
+    - {src: 'inputrc', dest: '~/.inputrc'}
+    - {src: 'bash_profile.ansible', dest: '~/.bash_profile.ansible'}
+    - {src: 'bashrc.ansible', dest: '~/.bashrc.ansible'}
 
 - name: Source rc.ansible files
-  lineinfile: path={{ item.path }} line={{ item.line }} create=true insertbefore=BOF
+  lineinfile: path={{ item.path }} line={{ item.line }} mode=0644 create=true insertbefore=BOF
   with_items:
-    - { path: '~/.bashrc', line: '. "$HOME"/.bashrc.ansible' }
-    - { path: '~/.bash_profile', line: '. "$HOME"/.bash_profile.ansible' }
+    - {path: '~/.bashrc', line: '. "$HOME"/.bashrc.ansible'}
+    - {path: '~/.bash_profile', line: '. "$HOME"/.bash_profile.ansible'}
 
 - name: Clone bash-git-prompt
   git:
     repo: https://github.com/magicmonty/bash-git-prompt.git
     dest: ~/.bash-git-prompt
-    clone: yes
-    update: no
+    clone: true
+    version: master
+    update: false
diff --git a/roles/zsh/tasks/main.yml b/roles/zsh/tasks/main.yml
index 6059674..60235d6 100644
--- a/roles/zsh/tasks/main.yml
+++ b/roles/zsh/tasks/main.yml
@@ -22,16 +22,16 @@
   when: ansible_facts['distribution'] == 'Debian'
 
 - name: Copy files
-  copy: src={{ item.src }} dest={{ item.dest }} backup=true
+  copy: src={{ item.src }} dest={{ item.dest }} backup=true mode=0644
   with_items:
-    - { src: 'zshrc', dest: '~/.zshrc' }
-    - { src: 'zshenv', dest: '~/.zshenv' }
-    - { src: 'zprofile', dest: '~/.zprofile' }
-    - { src: 'p10k.zsh', dest: '~/.p10k.zsh' }
+    - {src: 'zshrc', dest: '~/.zshrc'}
+    - {src: 'zshenv', dest: '~/.zshenv'}
+    - {src: 'zprofile', dest: '~/.zprofile'}
+    - {src: 'p10k.zsh', dest: '~/.p10k.zsh'}
 
 - name: Clone repos
-  git: repo={{ item.repo }} dest={{ item.dest }} clone=yes version={{ item.version }} update=no
+  git: repo={{ item.repo }} dest={{ item.dest }} clone=true version={{ item.version }} update=false
   with_items:
-    - { repo: 'https://github.com/softmoth/zsh-vim-mode.git', dest: '~/.git_clones/zsh-vim-mode', version: 'main' }
-    - { repo: 'https://github.com/zsh-users/zsh-autosuggestions.git', dest: '~/.git_clones/zsh-autosuggestions', version: 'master' }
-    - { repo: 'https://github.com/zsh-users/zsh-syntax-highlighting.git', dest: '~/.git_clones/zsh-syntax-highlighting', version: 'master' }
+    - {repo: 'https://github.com/softmoth/zsh-vim-mode.git', dest: '~/.git_clones/zsh-vim-mode', version: 'main'}
+    - {repo: 'https://github.com/zsh-users/zsh-autosuggestions.git', dest: '~/.git_clones/zsh-autosuggestions', version: 'master'}
+    - {repo: 'https://github.com/zsh-users/zsh-syntax-highlighting.git', dest: '~/.git_clones/zsh-syntax-highlighting', version: 'master'}